Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBAN detection #392

Merged
merged 2 commits into from
Aug 3, 2023
Merged

IBAN detection #392

merged 2 commits into from
Aug 3, 2023

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Aug 2, 2023 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • Add IBAN detection as PII sensetive info and good recognized data
  • Slight fixes in heroku rule with deprecation warning

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest A
  • Test Benchmark found nothing

@babenek babenek changed the title Iban IBAN detection Aug 2, 2023
@babenek babenek marked this pull request as ready for review August 2, 2023 19:35
@babenek babenek requested a review from a team as a code owner August 2, 2023 19:35
csh519
csh519 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding new IBAN rule.

LGTM 👍

@iuriimet iuriimet self-requested a review August 3, 2023 07:13
@babenek babenek merged commit cda354e into Samsung:main Aug 3, 2023
24 checks passed
@babenek babenek deleted the iban branch August 3, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuriimet iuriimet iuriimet approved these changes

@csh519 csh519 csh519 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babenek @iuriimet @csh519