Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIN detection #393

Merged
merged 11 commits into from
Aug 7, 2023
Merged

VIN detection #393

merged 11 commits into from
Aug 7, 2023

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Aug 2, 2023

Description

Please include a summary of the change and which is fixed.

  • Add VIN detection rule as PII

How has this been tested?

Please describe the tests that you ran to verify your changes.

@babenek babenek changed the title NDJSON is parsing with "-- depth" option (#390) VIN detection Aug 2, 2023
@babenek babenek marked this pull request as ready for review August 2, 2023 19:35
@babenek babenek requested a review from a team as a code owner August 2, 2023 19:35
csh519
csh519 previously approved these changes Aug 3, 2023
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding new VIN rule.

LGTM 👍

@babenek babenek marked this pull request as draft August 3, 2023 07:36
@babenek babenek marked this pull request as ready for review August 3, 2023 13:26
"""Check that value is a VIN"""
WEIGHTS = [8, 7, 6, 5, 4, 3, 2, 10, 0, 9, 8, 7, 6, 5, 4, 3, 2]
TRANSLITERATIONS = {
"0": 0,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAPF style :(

@babenek babenek merged commit cc25331 into Samsung:main Aug 7, 2023
24 checks passed
@babenek babenek deleted the vin branch August 7, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants