Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[luci/partition] Support RmsNorm operation #14030

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

seockho-kim
Copy link
Contributor

This commit supports RmsNorm operation in luci partition.

ONE-DCO-1.0-Signed-off-by: Seockho Kim [email protected]

issue: #13964
draft: #13967

@seockho-kim seockho-kim requested review from seanshpark and a team and removed request for seanshpark September 13, 2024 09:26
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark
Copy link
Contributor

[ RUN ] ConnectNodeTest.connect_RmsNorm
/__w/ONE/ONE/compiler/luci/partition/src/Nodes/CircleRmsNorm.test.cpp:72: Failure
Expected: loco::must_cast<luci::CircleRmsNorm *>(clone) doesn't throw an exception.
Actual: it throws std::invalid_argument with description "loco::must_cast() failed to cast: PN4luci13CircleRmsNormE".

This commit supports RmsNorm operation in luci partition.

ONE-DCO-1.0-Signed-off-by: Seockho Kim [email protected]
@seanshpark seanshpark merged commit 5dced7e into Samsung:master Sep 23, 2024
10 checks passed
@seockho-kim seockho-kim deleted the luci_partition_rmsnorm branch September 24, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants