Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Fixes screenshot issues #3700

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

benhammondmusic
Copy link
Collaborator

@benhammondmusic benhammondmusic commented Oct 1, 2024

Description and Motivation

TODO:

  • send correct file name for saved image
  • offer option to copy image to clipboard

Refactors

  • replace html2canvas with different package that allows easier hiding of elements on screenshot
  • continues more lazy loading of react components
  • removes unused of unneeded npm packages
  • brings largest bundle size down from ~1.3mb -> 0.89mb (over 30% reduction)
  • fixes "Save Image" menu option gets unwanted gray boxing on 2nd monitor #2186
  • prepend all saved files with HET - for easier sorting/finding when a user saves lots of images from our site
  • uses our APA citation at the bottom of the saved card

Has this been tested? How?

manually tested on MacOS, with NO external monitor:

  • arc (chromium browser)
  • safari
  • firefox

manually tested on MacOS, WITH external monitor (TV):

  • arc (chromium browser)

manually tested on Windows, with NO external monitor:

  • edge

Screenshots (if appropriate)

Saved Image Example (Mac)
my-image-name (32)
my-image-name (36)

Windows:
Screenshot 2024-10-01 at 1 49 43 PM

File Naming:
Screenshot 2024-10-01 at 2 11 54 PM

Types of changes

(leave all that apply)

  • Bug fix
  • Refactor / chore

New frontend preview link is below in the Netlify comment 😎

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for health-equity-tracker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ad2e8d0
🔍 Latest deploy log https://app.netlify.com/sites/health-equity-tracker/deploys/66fc4f99cee7220008a2529f
😎 Deploy Preview https://deploy-preview-3700--health-equity-tracker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benhammondmusic benhammondmusic changed the title Frontend: Fix screenshot issues Frontend: Fixes screenshot issues Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Save Image" menu option gets unwanted gray boxing on 2nd monitor
1 participant