Close custom substate on destroy #15572
Open
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should prevent crashing if the state was changed or reset while the substate is still active
LarryFrosty
changed the title
LarryFrosty
changed the title
|
Why did linux fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close the custom substate manually on destroy to prevent a crash that happens if the state gets reset or changed while the substate is still active
This PR also makes it so that
CustomSubstate.instanceis no longer set to null whencloseCustomSubstateis called, and is instead set to null whendestroyis calledAnyways, the reason that the custom substate crashes is most likely due to the substate being closed by Flixel itself, WAY after PlayState has already been destroyed
And thus, the game is trying to call
PlayState.instance.callOnScriptswhile theinstancevariable has already been set to null