Fix resolve_find_in_map when map has bool values #112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been seen in CloudFormation templates where maps contain bool values, where this resolver doesn't work on
False
. Even though it's able to find the correct value.Updating the condition so it returns both
True
andFalse
values, and failing if the value isNone
(default return on theget()
function).Added tests accordingly.
Updated cloudformation_actions and tests failing due to that.