Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JettyMockEngine logging/reporting #354

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

modax
Copy link
Contributor

@modax modax commented Jan 18, 2019

2 commits:

    Improve logging in JettyMockEngine
    
    Unify Started/Stopped log messages and log a warning when attempting to
    stop a mock service which does not exist (which most likely means there
    is a bug somewhere).
    Return HTTP 404 when requested mock service isn't found
    
    On all occasions mock service list is returned when requested mock
    service cannot be found. So it makes very much sense to return 404 in
    these cases (with running service as before).
    
    What is more, returning HTTP 200 is very misleading and might mislead
    callers into thinking that everything is fine.

On all occasions mock service list is returned when requested mock
service cannot be found. So it makes very much sense to return 404 in
these cases (with running service as before).

What is more, returning HTTP 200 is very misleading and might mislead
callers into thinking that everything is fine.
Unify Started/Stopped log messages and log a warning when attempting to
stop a mock service which does not exist (which most likely means there
is a bug somewhere).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant