Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move devices:capability-status command to yargs #629

Open
wants to merge 1 commit into
base: yargs
Choose a base branch
from

Conversation

rossiam
Copy link
Collaborator

@rossiam rossiam commented Oct 1, 2024

  • converted devices:capability-status to yargs
  • updated core-SDK version to have access to AttributeState type
  • converted and updated prettyPrintAttribute used by this command and a few others
    • the new version takes an AttributeState instead of just the value and returns an empty string if there is no value (previously every call that called this method made that same check)
    • updated code that calls this, including some places in not-yet-converted code
  • added fatalError function to util module to present the user with an error and exit with an error code
  • moved/updated/added unit tests for everything
  • added chooseComponentFn that replaces two versions of chooseComponent from old code
  • added table-mock helper module that is similar to the logger-mock modules and updated tests to use it

Copy link

changeset-bot bot commented Oct 1, 2024

⚠️ No Changeset found

Latest commit: 76dff96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rossiam rossiam force-pushed the yargs-devices-component-status branch from 6e9c7d6 to 76dff96 Compare October 1, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant