Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #17. Tag enforcement #18

Merged
merged 2 commits into from
Sep 21, 2023
Merged

closes #17. Tag enforcement #18

merged 2 commits into from
Sep 21, 2023

Conversation

hackertron
Copy link
Collaborator

No description provided.

@hackertron hackertron added the bug Something isn't working label Sep 19, 2023
@hackertron hackertron self-assigned this Sep 19, 2023
@tpantpan
Copy link

No 'submit tag' page anymore, tag creation capability will be part of the 'submit site' page. Unable to create tags just by themselves.

Something to consider: Will not be able to submit website without a tag, but want to make it more friendly (design preference is not to disable features). Will need to do some more design research on this.

@thebeyondr please create a new issue for this

Copy link
Member

@thebeyondr thebeyondr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ez but I suggested a more friendly error message

controllers/urls.js Outdated Show resolved Hide resolved
@hackertron hackertron merged commit a36bf31 into main Sep 21, 2023
@thebeyondr
Copy link
Member

@thebeyondr please create a new issue for this

Done: State-Channel-4/frontend#25

@hackertron hackertron deleted the fix/17 branch September 27, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants