Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/submit website #42

Merged
merged 28 commits into from
Dec 8, 2023
Merged

Feat/submit website #42

merged 28 commits into from
Dec 8, 2023

Conversation

Ian-Bright
Copy link
Contributor

Resolves:
#25
#33

Redesign of the submit website page. User can input a site url, description (title), and tags before submitting a video. Users also have the ability to add new tags through this page

@Ian-Bright
Copy link
Contributor Author

Two things have come to mind:

  1. Think it needs to be made more obvious that the slider is disabled when proper inputs have not been provided
  2. The description (title) seems like something we should require or have some default value provided if nothing is typed in

@thebeyondr thebeyondr added the ✨feature New feature or request label Dec 6, 2023
@thebeyondr
Copy link
Member

thebeyondr commented Dec 6, 2023

Think it needs to be made more obvious that the slider is disabled when proper inputs have not been provided

I'd prefer to show good error messages under the relevant input element than disabling the button

The description (title) seems like something we should require or have some default value provided if nothing is typed in

Agreed, we should require this. I don't think we should provide a default value though

@ChialiT please weigh in on these^^

Some requests before approval:

  • Make the preview trigger after the focus is removed from the input (onBlur)
  • The label text size seems too big

👏🏽 Great stuff so far, glad to see this transformed from design to usable UI!

@Ian-Bright
Copy link
Contributor Author

Took care of those items we discussed and your requests before merging @thebeyondr

@thebeyondr
Copy link
Member

thebeyondr commented Dec 7, 2023

@Ian-Bright looks good, discovered a few things

  1. I can trigger the url send mid while a tag is being created (pic related)
  2. The sign in link in the nav menu didn't seem to be working
  3. When I'm not signed in and attempt to sign in with Google the page doesn't reload. I don't have an account so it should be a sign-up operation instead of a sign-in one

image

@Ian-Bright
Copy link
Contributor Author

Ok disabled the slider when creating a tag. The sign in bugs I cannot reproduce. I've had something similar before on an earlier branch where I needed to refresh. Are there any steps to reproduce on your end @thebeyondr ?

@thebeyondr thebeyondr merged commit 5ab25a3 into feat/v0.3 Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants