Android fullscreen via bridging #38
Conversation
|
Thanks for this commit. |
|
@cornedor Nope, readme says it all. |
|
Ah I didn't see that, thanks. I'll try to make this work with react-native link. |
|
@cornedor Can you check my pull request? It is native and performs better than react because in react you would have to resize the video component which is unstable where native video player fixes it all in native so please check my request and merge it. Thank you. |
|
@ShariqMush yes I agree, I have more time after next week, so I will try to make it work with react-native link. If you update the app now you will need to manually copy the files from the repo to your own project. I do appreciate all the work you did to get it this far. |
|
I spent the last few days looking for the best full-screen android option for RN and I think this pull request is the best available. A few issues though. 1 - No option to leave fullscreen (other than the back button) once in fullscreen. I have written fixes to both of these issues (doubleclick on fullscreen to close and passing of position between activities), though I have not tested it much, would appreciate someone else running their eyes over it to make sure I've not missed anything? |
|
This works great, but fullscreen has native controls, not the react-native-video-player controls. Can something be done about this, or is it too compilcated? |
|
@Misiur Yes it is very complicated, why would you need the react controls when you are already getting the native controls? |
|
Missing back-from-fullscreen button, missing volume controls, just all around missing functionality - that's why I'm using react-native-video-player in the first place! (well, and your awesome native fullscreen functionality) |
|
@Misiur For the back button, why not use the ordinary back button on any android device lol but I can look at the volume controls for you but then its pretty much like the player rebuilt into the native but yeah I will look forward to it but please post an issue on my fork. I will be posting further updates there until this pull request gets accepted. |
Made a stop function
Callbacks on start/play
|
Any update on that one? would be great if you could merge it, I was not able to make it work following the described steps. Thanks! |
|
|
||
| public class BridgePackage implements ReactPackage { | ||
|
|
||
| @Override |
There was a problem hiding this comment.
from RN 0.47.x on the createJSModules() method has been removed and thus the @Override implement here will fail the gradle compilation. Simply remove the @Override and keep the method call should resolve this issue.
| import PropTypes from 'prop-types'; | ||
| import { Image, Platform, StyleSheet, TouchableOpacity, View, ViewPropTypes } from 'react-native'; | ||
| import React, { Component, PropTypes } from 'react'; | ||
| import { View, StyleSheet, Image, TouchableOpacity, Platform, NativeModules } from 'react-native'; |
There was a problem hiding this comment.
Any specific reasons for changing to use the built-in PropTypes instead of the separate prop-types library?
There was a problem hiding this comment.
built-in PropTypes are breaking since react does not support them, we should use separate prop-types library.
|
@Misiur I agree with you, native control don't have back fullscreen, and the control are hard to make a custom control bar like without fullscreen |
|
+1 |
|
@ShariqMush , @abrown1982: Ot, I have a problem, I created a native module, but when you start the native module all right, it works. But if the user presses the physical back button, the app crashes, how can I fix this? I would like when the user presses the physical back button, he returns to the native react app at the point I had left before the native module started. |
|
@ShariqMush Native player is working fine, but no callbacks are working in full screen mode, like onEnd, onFullscreenPlayerDidDismiss etc. how can we register these events in fulscreen mode as that of ios. |
|
@abrown1982 can you pleae help me in adding callbacks(onEnd,onFullscreenPlayerDidDismiss etc ) on full screen mode. |
|
@kashifaliquazi I'm working to a deadline at the moment so don't have any time available in the next week or so. |
|
I have been away from my computer but I'll be updating the fork asap with the callbacks. |
|
@ShariqMush I installed your library but the fullscreen button is not present anyway. |
|
It's been a month since the last update here... Any news? |
|
I too tried with PR#38 no errors but the fullscreen button on Android does not show. I am using react native video player version #0.9.1. Any update please? |
|
Would love to see the FullScreen work. |
|
@hoscarcito @SujaYuga @xstable @Ilario17 I have been inactive for a while but will look at what the problem is very soon. Check forks of my own fork and there you should find some working ones. |
|
@ShariqMush Any progress here? |
|
@xstable Hi, I am not working with react native at the moment but I believe that the issue is related to react native library not any problem in the native code. If fullscreen button does not appear then you should tamper with the library files. Try pulling my fork of the video player to see if it works because some people made some PR's that I merged recently. |
@abrown1982 is there a chance to have a classic "x" as close-button in the Fullscreen-View? |
|
is there any update for full screen mode on android?????? |
|
Hey guys! Any news? We're getting tired of stretching video components manually. |
We need fullscreen feature on Android. |
|
@iamshadmirza Isn't the issue with the fullscreen fixed yet? I am not working with react native anymore :) |
|
@ShariqMush any updates regarding full screen mode on android? |
|
Please fix this ASAP |
|
I verified that this PR is not working out of the box, not even after following the complex guidelines added in the README.md file. Will be looking into this and keep you all updated. |
|
tried to config like this and still not working |
|
It's a bit old but: is there any news regarding fullscreen for android? |
Native bridge to android launching android video view in fullscreen, hours of work of sweat and tears!!!
To all the other developers, please use this github library for working fullscreen until the developer of this library merges the pull request :) I will be updating that fork as well.