Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parse): offset parsing when seconds are decimal #33

Merged

Conversation

waynec86
Copy link
Contributor

Context

This addresses #32
as well as adds test cases for when seconds of a timestamp are represented as a decimal, the offset +/-HH:MM is not respected for the timezone offset

Test Plan

Added 3 more tests and verified no other tests break

@Tieske Tieske force-pushed the waynec86/fix-date-offset-with-decimal-seconds branch from 5abbd0f to 8566b5f Compare September 6, 2023 15:39
@Tieske Tieske changed the title Fix offset parsing when seconds are decimal fix(parse): offset parsing when seconds are decimal Sep 6, 2023
@Tieske Tieske merged commit b20176c into Tieske:master Sep 6, 2023
7 checks passed
@Tieske
Copy link
Owner

Tieske commented Sep 6, 2023

@waynec86 thx for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants