Update colors and widget appearance for UI #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should have a consistent color set over all widgets.
Work around a bug in Fl_Input_Choice where it forgets to set the proper "input background" on some parts.
Inspired by modern Windows appearance, and to some extent macOS. They have flat boxes and use white, or very light, colors for interactive elements. Unfortunately we can't directly control the colors of widgets, so instead we just lighten everything that uses this box type. GNOME uses a different design, both their older and newer style. But UI look is less consistent on Linux, so hopefully our new look is decent enough there as well.
There is something broken with these FLTK draw routines on Windows. They leave gaps at the start and end of the arc/pie rather than filling the whole specified span. So we need to nudge the numbers a bit to work around this.
Follow the colors that modern desktops use when it comes to background, text and selections.
|
Looks nice when I build things myself on Fedora 38, but the RHEL9 nightly (from http://tigervnc.bphinz.com/nightly/) looks wrong:
|
|
Huh. Very odd. I can reproduce it by rebuilding the RPM packages on a RHEL 9 machine here. It doesn't happen if I build TigerVNC manually on the same machine though. |
|
After some more digging, the triggering condition is enabling PIC/PIE, which Red Hat does by default for RPM builds. Unclear why this breaks things, though. |
|
Found it. Box types cannot be larger than 255, and unfortunately FLTK doesn't protect against this. So we were doing out-of-bounds access. PIC/PIE changes the memory layout, which fortunately was enough to make the issue visible. |
|
Fixed in 4cef5c9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another part broken out of #1410. This time it is updating the colors to match modern systems better, and a new look for the widgets (as much as FLTK easily allows).
This is mainly trying to mimic Windows Fluent, but that is also close to macOS styling. It doesn't follow GNOME's adwaita (old or new), but UI look is less standardised on Linux so it should be acceptable there as well.
Before:
After: