Pin dep versions to retain compatibility with ESLint 8, TSLint 7 #2
Conversation
Was seemingly using the install-peerdeps syntax of `--dev` for an npm command, rather than either `--save-dev` or `-D`. For consistency with the example yarn command, went with `-D`.
…ts with TSESLint 8 At the current time, attempting to install using the previous peer-dev of v4 throws a version mis-match that npm cannot resolve, as the latest is v8, but AirBnB requires v7 and is NOT compatible with v8. This is because of the ongoing transition to ESLint 9 (and TSESLint 8), which AirBnB does not yet support. Simply pinning to v7 solves it.
There was a problem hiding this comment.
Thanks for bringing this to my attention - the migration to ESLint v9 is definitely a tricky situation. I'll continue to keep an eye on the AirBnB config, etc. and update this to the new structure once possible.
I'm somewhat considering dropping AirBnB and cherry-picking the rules I'd like to keep from it. This config has diverged a fair bit from it since inception.
|
That would totally make sense. FWIW, in no way would this PR preempt that. It just gets everything working as intended again, until whenever that happens. It's basically just a bug-fix, while creating some awareness of the ESLint migration. |
There was a problem hiding this comment.
That would totally make sense. FWIW, in no way would this PR preempt that. It just gets everything working as intended again, until whenever that happens. It's basically just a bug-fix, while creating some awareness of the ESLint migration.
Sounds reasonable.
LGTM, I'll get this merged and push a new version to npm
Hi, and thanks for this great, opinionated config. It should be adopted en masse!
While installing and configuring, I ran into some problems because of the new version of ESLint, which changes A LOT. Similarly ESTSLint also has a new, matching version.
But, AirBnB hasn't yet updated their configs to be compatible. (See: Issue) So, that means users of this config will need to consciously stick with ESLint v8 and ESTSLint v7 for now, at least until AirBnB finishes adding support.
So, I propose these related changes (each is a separate commit):