Update nx config for tests #2685
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests only require that the dependencies have been built, not the package itself
|
This might not be worth merging if we're taking #2682 instead, or it would at least need to be revisited. |
mfedderly
force-pushed
the
mf/nx-cleanup
branch
from
e534ee6
to
bbcff19
Compare
|
I reworked this to just not conflict with that PR, we can merge this safely now. |
twelch
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where nx would cache test runs even if the underlying files have changed. This only happens if you execute tests like so:
This invokes the lerna/nx caching layer, and this will miss the fact that the actual code itself changed which should cause the tests to rerun. To fix this I extracted the source file inputs into a named input, and then used that in both build and test so that everything stays in sync.