Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aqua tests and fix method ambiguity #92

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Add Aqua tests and fix method ambiguity #92

merged 2 commits into from
Aug 3, 2023

Conversation

devmotion
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Pull Request Test Coverage Report for Build 5751839064

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 96.655%

Totals Coverage Status
Change from base Build 5748883440: 0.008%
Covered Lines: 838
Relevant Lines: 867

💛 - Coveralls

Copy link
Member

@sethaxen sethaxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass, LGTM

@devmotion devmotion closed this Aug 3, 2023
@devmotion devmotion reopened this Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3689384) 96.64% compared to head (c143ba3) 96.65%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   96.64%   96.65%           
=======================================
  Files          11       11           
  Lines         865      867    +2     
=======================================
+ Hits          836      838    +2     
  Misses         29       29           
Files Changed Coverage Δ
src/rstar.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devmotion devmotion merged commit fece47d into main Aug 3, 2023
11 checks passed
@delete-merged-branch delete-merged-branch bot deleted the dw/aqua branch August 3, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants