This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
v2 quote with fee-on-transfer tax considerations #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgkol
reviewed
Sep 8, 2023
jsy1218
force-pushed
the
jsy1218/v2-pair-quote-consider-fot-fees
branch
from
38d19d2
to
ff3671b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we quote against v2 pairs, if the token(s) is/are fee-on-transfer tokens, we essentially do not take them off the amountIn/amountOut. This is incorrect, and we want to consider the fee-on-transfer tokens when calculating the quotes in smart-order-router quote-provider getQuotes.
One thing is that the reserves are not updated. Most likely fee-on-transfer tokens do deplete the reserves, so the correct calculations should take off of the reserves. However since smart-order-router refreshes reserves per block, and router doesn't persisted its own reserve state, we don't have to update the reserve calculation here.