fix: usr: clean up memory leaks found with valgrind #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get the test apps to pass 'valgrind --leak-check=full' without
any leaks detected.
* redis_ipc.c - add some missing frees
* json.hh - fix reference management
* get_field(): the json constructor of return value will automatically
take a reference on the wrapped json_object, so don't need to manually
bump reference count with json_object_get()
* set_field() with json value: *do* manually take reference so the value
object passed in will not be destroyed when the newly assigned
parent object gets destroyed, since "add" does not bump reference
count but later parent will try to clean it up
|
This is now non-WIP, think I've got the JSON reference counting nailed down now. |
* switch back to *not* take an extra reference on json_object ptr
that gets passed in, to make things convenient for typical external
usage of this constructor. This makes behavior match the exception
mentioned in original comment about constructors:
// normally want to take reference on underlying json_object*,
// except for case of initializing from an existing raw json_object*
// such as those returned by redis_ipc -- those start out with a reference
which means that callers no longer need to remember to call json_object_put()
after wrapping a raw json_object with json class
* add a new comment right above tha constructor highlighting that
this constructor wrapping an existing json_object does *not* bump
the reference count
* fix memory leak in operator=() by forgetting to json_object_put()
before overwriting with a new value
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the test apps to pass 'valgrind --leak-check=full' without any leaks detected.
redis_ipc.c - add some missing frees
json.hh - fix reference management