Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supports plural condition for the plural form #12053

Conversation

harriebird
Copy link
Collaborator

Proposed changes

The plural form currently is displayed if plural.number > 1 and forgot to check if the format supports plurals. This will add another condition to see if the format set in the component supports plurals.
This solves issue #12044.

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@harriebird harriebird force-pushed the fix/add-supports-plural-condition-for-the-plural-form branch 2 times, most recently from 3a7d089 to 2619934 Compare July 15, 2024 06:41
@nijel nijel linked an issue Jul 15, 2024 that may be closed by this pull request
2 tasks
@nijel nijel added this to the 5.7 milestone Jul 15, 2024
@nijel nijel self-assigned this Jul 15, 2024
@nijel nijel force-pushed the fix/add-supports-plural-condition-for-the-plural-form branch from 2619934 to 30e4e58 Compare July 15, 2024 06:56
@nijel nijel enabled auto-merge (rebase) July 15, 2024 06:59
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.58%. Comparing base (6aee586) to head (30e4e58).
Report is 2566 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12053      +/-   ##
==========================================
- Coverage   90.82%   90.58%   -0.24%     
==========================================
  Files         554      582      +28     
  Lines       57306    59284    +1978     
  Branches     9122     9470     +348     
==========================================
+ Hits        52046    53705    +1659     
- Misses       3640     3871     +231     
- Partials     1620     1708      +88     
Files Coverage Δ
weblate/trans/views/basic.py 81.56% <ø> (-1.36%) ⬇️

... and 358 files with indirect coverage changes

@nijel nijel merged commit 650059f into WeblateOrg:main Jul 15, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plural fields missing when adding glossary
2 participants