Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unit): always generate change for explanation edit #12567

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

nijel
Copy link
Member

@nijel nijel commented Sep 23, 2024

Proposed changes

It was missed when editing source.

Fixes #12550

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel added this to the 5.8 milestone Sep 23, 2024
@nijel nijel self-assigned this Sep 23, 2024
@nijel nijel enabled auto-merge (rebase) September 23, 2024 11:52
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.10%. Comparing base (c050f1c) to head (ee9034a).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
weblate/trans/models/unit.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12567   +/-   ##
=======================================
  Coverage   91.10%   91.10%           
=======================================
  Files         591      591           
  Lines       60580    60581    +1     
  Branches     9593     9593           
=======================================
+ Hits        55191    55192    +1     
  Misses       3721     3721           
  Partials     1668     1668           
Files with missing lines Coverage Δ
weblate/trans/models/unit.py 87.78% <50.00%> (+0.01%) ⬆️

@nijel nijel merged commit ecd869f into WeblateOrg:main Sep 23, 2024
34 of 35 checks passed
@nijel nijel deleted the explanation-change branch September 23, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant