Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate notification duplicates #9483

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Conversation

nijel
Copy link
Member

@nijel nijel commented Jun 29, 2023

Proposed changes

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel added this to the 5.0 milestone Jun 29, 2023
@nijel nijel enabled auto-merge (rebase) June 29, 2023 12:52
When user subscribes both ChangedStringNotificaton and TranslatedStringNotificaton
some events would be delivered twice.

Fixes WeblateOrg#9464
There is already enough copies of the code, so let's make it generic.
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #9483 (58d7de1) into main (69f5929) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9483      +/-   ##
==========================================
- Coverage   90.85%   90.83%   -0.02%     
==========================================
  Files         719      731      +12     
  Lines       54235    54413     +178     
  Branches     8356     8394      +38     
==========================================
+ Hits        49276    49427     +151     
- Misses       3448     3455       +7     
- Partials     1511     1531      +20     
Impacted Files Coverage Δ
...s/0026_alter_subscription_notification_and_more.py 100.00% <100.00%> (ø)
weblate/accounts/notifications.py 96.30% <100.00%> (+0.81%) ⬆️
weblate/accounts/tests/test_notifications.py 100.00% <100.00%> (ø)

... and 57 files with indirect coverage changes

@nijel nijel disabled auto-merge June 30, 2023 06:09
@nijel nijel merged commit 5a57e83 into WeblateOrg:main Jun 30, 2023
23 checks passed
@nijel nijel deleted the notify-duplicates branch June 30, 2023 06:09
@nijel nijel self-assigned this Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate notifications
1 participant