Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use more comprehensions #9503

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Conversation

nijel
Copy link
Member

@nijel nijel commented Jul 4, 2023

Proposed changes

Utilize comprehensions in more situations. This should slightly improve the performance and makes the code easier to read in many cases.

Discovered by ruff PERF401, needed for #9500

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel added this to the 5.0 milestone Jul 4, 2023
@nijel nijel self-assigned this Jul 4, 2023
@nijel nijel enabled auto-merge (rebase) July 4, 2023 09:24
Utilize comprehensions in more situations. This should slightly improve
the performance and makes the code easier to read in many cases.

Discovered by ruff PERF401
@nijel nijel merged commit a8c3533 into WeblateOrg:main Jul 4, 2023
21 checks passed
@nijel nijel deleted the perf-comprehensions branch July 4, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant