Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use lazy evaluated annotations #9550

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

nijel
Copy link
Member

@nijel nijel commented Jul 13, 2023

Proposed changes

Utilize PEP 563: Postponed evaluation of annotations

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

Use PEP 563: Postponed evaluation of annotations
@nijel nijel added this to the 5.0 milestone Jul 13, 2023
@nijel nijel enabled auto-merge (rebase) July 13, 2023 06:10
@nijel nijel self-assigned this Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #9550 (636894a) into main (c53a67b) will decrease coverage by 0.01%.
The diff coverage is 92.40%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9550      +/-   ##
==========================================
- Coverage   90.99%   90.98%   -0.01%     
==========================================
  Files         732      733       +1     
  Lines       54429    54468      +39     
  Branches     8390     8393       +3     
==========================================
+ Hits        49526    49559      +33     
- Misses       3403     3406       +3     
- Partials     1500     1503       +3     
Impacted Files Coverage Δ
weblate/utils/lock.py 77.35% <42.10%> (+1.35%) ⬆️
weblate/trans/models/component.py 80.91% <50.00%> (-0.13%) ⬇️
weblate/trans/models/translation.py 87.15% <50.00%> (-0.21%) ⬇️
weblate/vcs/mercurial.py 91.58% <75.00%> (-0.87%) ⬇️
weblate/vcs/base.py 92.22% <85.71%> (-0.69%) ⬇️
weblate/vcs/git.py 84.94% <93.10%> (-0.19%) ⬇️
weblate/accounts/models.py 88.61% <100.00%> (ø)
weblate/accounts/notifications.py 96.31% <100.00%> (+<0.01%) ⬆️
weblate/accounts/tests/test_notifications.py 100.00% <100.00%> (ø)
weblate/accounts/tests/test_utils.py 100.00% <100.00%> (ø)
... and 56 more

... and 2 files with indirect coverage changes

@nijel nijel merged commit 8e6cd82 into WeblateOrg:main Jul 13, 2023
24 checks passed
@nijel nijel deleted the annotations branch July 13, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant