Add subscription deferral for Google play #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronkorving
reviewed
May 15, 2019
|
I would love some feedback from other Google Play users (as I am not one). |
|
At our company we're running this code in production since January and have used this function a few thousand times (to delay some subscription payments). It's been stable and reliable so far, never had a problem with it. It would be great to see it merged 🚢 |
|
@antonio0 Could you update this to use Google API v3? |
@ronkorving just updated now to v3 |
ronkorving
reviewed
Nov 22, 2019
|
|
||
| if (!engine.deferSubscription) { | ||
| return syncError(new Error(`Platform ${platform | ||
| } does not have deferSubscription method`)); |
There was a problem hiding this comment.
Was the line too long for lint's liking?
[Apple] Check for cancellation_date_ms first If cancellation date is available it means that Apple Customer Support refunded subscription payment. From Apple: To check whether a purchase has been canceled by Apple Customer Support, look for the Cancellation Date field in the receipt. If the field contains a date, regardless of the subscription’s expiration date, the purchase has been canceled. With respect to providing content or service, treat a canceled transaction the same as if no purchase had ever been made.
Referencing the following documentation: https://developer.apple.com/documentation/appstorereceipts/status We can see that 21009 and 21010 are available codes we should handle.
|
@antonio0 With nine commits might make sense to squash? |
…nto google-defer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented this functionality: https://developers.google.com/android-publisher/api-ref/purchases/subscriptions/defer
I know for sure that Apple doesn't provide an analogous functionality, not sure about the other providers though.