Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout to requests calls #617

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −8
Open

Add timeout to requests calls #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d60073
Add timeout to `requests` calls (#1)
pixeeai Aug 23, 2024
9884665
Merge branch 'main' into main
pixeeai Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions backend/utils/request/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ def make_http_request(
"""Generic helper function to help make a HTTP request."""
try:
if verb == HTTPMethod.GET:
response = pyrequests.get(url, params=params, headers=headers)
response = pyrequests.get(url, params=params, headers=headers, timeout=60)
elif verb == HTTPMethod.POST:
response = pyrequests.post(url, json=data, params=params, headers=headers)
response = pyrequests.post(url, json=data, params=params, headers=headers, timeout=60)
elif verb == HTTPMethod.DELETE:
response = pyrequests.delete(url, params=params, headers=headers)
response = pyrequests.delete(url, params=params, headers=headers, timeout=60)
else:
raise ValueError("Invalid HTTP verb. Supported verbs: GET, POST, DELETE")

Expand Down
6 changes: 3 additions & 3 deletions prompt-service/src/unstract/prompt_service/utils/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ def make_http_request(
"""Generic helper function to help make a HTTP request."""
try:
if verb == HTTPMethod.GET:
response = pyrequests.get(url, params=params, headers=headers)
response = pyrequests.get(url, params=params, headers=headers, timeout=60)
elif verb == HTTPMethod.POST:
response = pyrequests.post(url, json=data, params=params, headers=headers)
response = pyrequests.post(url, json=data, params=params, headers=headers, timeout=60)
elif verb == HTTPMethod.DELETE:
response = pyrequests.delete(url, params=params, headers=headers)
response = pyrequests.delete(url, params=params, headers=headers, timeout=60)
else:
raise ValueError("Invalid HTTP verb. Supported verbs: GET, POST, DELETE")

Expand Down
4 changes: 2 additions & 2 deletions unstract/tool-sandbox/src/unstract/tool_sandbox/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def make_get_request(
"""
url = f"{self.base_url}{endpoint}"
params = {"image_name": image_name, "image_tag": image_tag}
response = requests.get(url, params=params)
response = requests.get(url, params=params, timeout=60)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here It might get issue because, some tools need to be run more than 60 seconds. It's better to do with some env variables,

result: Optional[dict[str, Any]] = None
if response.status_code == 200:
result = response.json()
Expand Down Expand Up @@ -93,7 +93,7 @@ def call_tool_handler(
settings,
)

response = requests.post(url, json=data)
response = requests.post(url, json=data, timeout=60)
result: Optional[dict[str, Any]] = None
if response.status_code == 200:
result = response.json()
Expand Down