Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: support packages that only have manylinux 2 wheels #191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mathiasburger
Copy link

Currently onnxruntime==1.19.2 cannot be analyzed with python-inspector, because get_supported_wheels() is unable to process packages that only have manylinux wheels. E.g. https://pypi.org/project/onnxruntime/#files only contains the file ' onnxruntime-1.19.2-cp311-cp311-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl' for the x86_64 architecture.

Steps to reproduce the error:

Option a)

Remove the added manylinux platforms from utils_pypi.py and the test will fail.

Option b)

Execute

from pathlib import Path

from python_inspector.resolve_cli import resolve_dependencies

if __name__ == '__main__':
    resolve_dependencies(
        python_version="311",
        operating_system="linux",
        json_pdt=str(Path(__file__).parent / "debug-resolve-onnxruntime.txt"),
        analyze_setup_py_insecurely=True,
    )

with debug-resolve-onnxruntime.txt having the following content:

onnxruntime==1.19.2

Currently onnxruntime==1.19.2 cannot be analyzed with python-inspector, because get_supported_wheels() is unable to process packages that only have manylinux wheels. E.g. https://pypi.org/project/onnxruntime/#files only contains the file '
onnxruntime-1.19.2-cp311-cp311-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl' for the x86_64 architecture.

Signed-off-by: Mathias Burger <[email protected]>
@mathiasburger mathiasburger force-pushed the bugfix/manylinux-2-package-inspection branch from d1f953f to 2ddd952 Compare September 26, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant