Skip to content

Code injection in `saved_model_cli`

High severity GitHub Reviewed Published Nov 4, 2021 in tensorflow/tensorflow • Updated Feb 2, 2023

Package

pip tensorflow (pip)

Affected versions

>= 2.5.0, < 2.5.2
< 2.4.4
>= 2.6.0, < 2.6.1

Patched versions

2.5.2
2.4.4
2.6.1
pip tensorflow-cpu (pip)
>= 2.5.0, < 2.5.2
< 2.4.4
>= 2.6.0, < 2.6.1
2.5.2
2.4.4
2.6.1
pip tensorflow-gpu (pip)
>= 2.5.0, < 2.5.2
< 2.4.4
>= 2.6.0, < 2.6.1
2.5.2
2.4.4
2.6.1

Description

Impact

TensorFlow's saved_model_cli tool is vulnerable to a code injection as it calls eval on user supplied strings

def preprocess_input_exprs_arg_string(input_exprs_str):
  ... 
  for input_raw in filter(bool, input_exprs_str.split(';')):
    ...
    input_key, expr = input_raw.split('=', 1)
    input_dict[input_key] = eval(expr)
  ...

This can be used by attackers to run arbitrary code on the plaform where the CLI tool runs.
However, given that the tool is always run manually, the impact of this is not severe. We have patched this by adding a safe flag which defaults to True and an explicit warning for users.

Patches

We have patched the issue in GitHub commit 8b202f08d52e8206af2bdb2112a62fafbc546ec7.

The fix will be included in TensorFlow 2.7.0. We will also cherrypick this commit on TensorFlow 2.6.1, TensorFlow 2.5.2, and TensorFlow 2.4.4, as these are also affected and still in supported range.

For more information

Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.

Attribution

This vulnerability has been reported by Omer Kaspi from Vdoo.

References

@mihaimaruseac mihaimaruseac published to tensorflow/tensorflow Nov 4, 2021
Published by the National Vulnerability Database Nov 5, 2021
Reviewed Nov 8, 2021
Published to the GitHub Advisory Database Nov 10, 2021
Last updated Feb 2, 2023

Severity

High

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Local
Attack complexity
High
Privileges required
High
User interaction
None
Scope
Changed
Confidentiality
High
Integrity
High
Availability
High

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:L/AC:H/PR:H/UI:N/S:C/C:H/I:H/A:H

EPSS score

0.065%
(29th percentile)

CVE ID

CVE-2021-41228

GHSA ID

GHSA-3rcw-9p9x-582v

Source code

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.