Update base image to python-3.11.3 #455
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhollas
force-pushed
the
python-3.10.11
branch
from
53fbd49
to
c644ba0
Compare
danielhollas
force-pushed
the
python-3.10.11
branch
from
e0bdb6e
to
5ed097a
Compare
danielhollas
force-pushed
the
python-3.10.11
branch
from
6740395
to
e52ca1e
Compare
|
Blocked on aiidalab/aiidalab#428 |
|
Hi @danielhollas, I reconsidered if use jupyter stack as the base image is a good option, instead if we move to using aiida-core images could gaining more flexibility. Major two reasons are:
Let me know your opinion. |
danielhollas
commented
Jun 22, 2024
This was referenced Jun 22, 2024
|
Blocked on aiidalab/aiidalab#429 @unkcpz I've created #471, we shouldn't be discussing these foundational thing in PRs. |
|
Yep, just came to this PR when I start to try with notebook v7. Great you open an issue for this, I agree it is premature to move to that, this is just things come to my mind and want to get to know your opinions. Let’s have follow up discussion on the issue you opened.
Gesendet von Outlook für iOS<https://aka.ms/o0ukef>
…________________________________
Von: Daniel Hollas ***@***.***>
Gesendet: Saturday, June 22, 2024 7:12:18 PM
An: aiidalab/aiidalab-docker-stack ***@***.***>
Cc: Jusong Yu ***@***.***>; Mention ***@***.***>
Betreff: Re: [aiidalab/aiidalab-docker-stack] Update base image to python-3.10.11 (PR #455)
Blocked on aiidalab/aiidalab#429<aiidalab/aiidalab#429>
@unkcpz<https://github.com/unkcpz> I've created #471<#471>, we shouldn't be discussing these foundational thing in PRs.
—
Reply to this email directly, view it on GitHub<#455 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACDMFRJIEIKK6TADBBHT2JLZIWV7FAVCNFSM6AAAAABHVEF3JGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBUGEYTGMJSGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Yeah, if you want to start to play with NB7, you can start with this PR and set |
danielhollas
changed the title
danielhollas
force-pushed
the
python-3.10.11
branch
from
72023df
to
01e7258
Compare
danielhollas
commented
Sep 8, 2024
| mamba install --yes \ | ||
| aiida-core==${AIIDA_VERSION} \ | ||
| mamba-bash-completion \ | ||
| traitlets=5.9.0 \ |
There was a problem hiding this comment.
The base image already comes with traitlets==5.9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #265
NOTE: Upgrading Python is a breaking changes, since existing App need to be reinstalled due to #317