Fix doit tests #458
Merged
Fix doit tests #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhollas
commented
May 24, 2024
| @@ -55,21 +55,21 @@ The build system will attempt to detect the local architecture and automatically | |||
| All commands `build`, `tests`, and `up` will use the locally detected platform and use a version tag based on the state of the local git repository. | |||
| However, you can also specify a custom platform or version with the `--platform` and `--version` parameters, example: `doit build --arch=arm64 --version=my-version`. | |||
|
|
|||
| You can specify target image variants to build with `--target`, example: `doit build --target base --target lab`. | |||
There was a problem hiding this comment.
To simplify the code, you can now only provide a single --target argument (and we now automatically validate that you choose one of the four valid images. If no target is specified, then all images are built by default.
danielhollas
commented
May 24, 2024
| @@ -15,23 +15,25 @@ | |||
|
|
|||
| _ARCH_MAPPING = { | |||
| "x86_64": "amd64", | |||
| "amd64": "amd64", | |||
There was a problem hiding this comment.
This is what podman returns on Fedora 39 at least.
|
I've merged this since changes here don't influence the build / image itself, and we can always tweak later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #451. You can now build images locally with e..g
doit buildand then run tests as
doit tests -t full-stackI've also made some tweaks to support podman (and podman-compose) via extra
--compose-cmdarguments. I've also fixed thedoit upanddoit downcommands, which now have to include the-t/--targetargument.