Add bc for computing resources required by qeapp image #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @danielhollas, why the test is going to upload to registry? Should I open PR from origin repo? |
| @@ -10,7 +10,8 @@ USER root | |||
| # https://pymatgen.org/installation.html#installation-tips-for-optional-libraries | |||
| # rsync: needed to support the new AiiDA backup command | |||
| # povray: rendering engine used in aiidalab-widgets-base | |||
| ENV EXTRA_APT_PACKAGES "curl povray rsync build-essential" | |||
| # bc: needed to compute the resources for computer setup | |||
There was a problem hiding this comment.
Is this really needed? We could always use a Python one liner.
There was a problem hiding this comment.
I don't want to use python, bc is a tiny thing and all computation just happened in shell script.
I mean not from my forked repo but from |
|
Ah, sorry, I am on a phone app and it did not show me that this PR is from a fork. Yes, for this repo you always have to open the PRs from the origin. |
|
Replaced by #499 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.