Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for tcp.echo, tls.echo and http.kafka.sync examples #126
Tests for tcp.echo, tls.echo and http.kafka.sync examples #126
Changes from all commits
4b88639
11b41e4
a4355ca
c5ffe4e
fa4c1fa
396975f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use
apt
packagekafkacat
instead of this manual install?https://github.com/edenhill/kcat?tab=readme-ov-file#install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The apt package
kafkacat
installs kafkacat version 1.6.0 that means it's lagging ca. one year behind the latest release. Even if we installed that we'd need to do some manual steps (e.g. renaming the executable from kafkacat to kcat) to keep the test in sync with the README and executable on other systems (e.g. on a Mac which has the latest kcat installed with brew).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I tested it, and that approach runs the test green, too. This is the alternative configuration:
Pls LMK which one you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted the apt install commit as discussed, so going back to manual installation of kcat, as the decision was to install the latest version.