Joplin Desktop: Support arm64 and Asahi Linux #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is interesting, I am now starting to consider arm64 for the daily usage, can you rebase the Pull Request? |
|
@alfredopalhares Done, and I removed the electron override bit because it shouldn't be needed anymore. Note, I don't have an Arch instance to test this on at the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only small changes are needed to support ARM64, including Asahi Linux
distdirectory because the directory isdist/linux-arm64-unpackedwhen built on an arm64 machineUpgrade Electron to 19.0.10. This change is needed for Asahi Linux due to the kernel only supporting 16k page sizes. Electron < 19.0.0 just crashes on start up in Asahi Linux. Since this change is not needed for all ARM64 devices I'm happy to move it to a different PR if you'd like. Here is the upstream PR to upgrade Electron in Joplin desktop.This should no longer be needed since upstream is on a much newer Electron version