fix lifecycle

alibaba · Jul 3, 2024 · f963967 · f963967
1 parent 4e440e5
commit f963967
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/GaiaXAndroid/src/main/kotlin/com/alibaba/gaiax/render/view/container/GXGridView.kt b/GaiaXAndroid/src/main/kotlin/com/alibaba/gaiax/render/view/container/GXGridView.kt
@@ -69,12 +69,14 @@ open class GXGridView : GXContainer, GXIRelease {
                         if (Log.isLog()) {
                             Log.e(gxTemplateContext.tag, "traceId=${gxTemplateContext.traceId} tag=GXGridView.release GXScrollView=$this gxView=$gxView")
                         }
-                        GXTemplateEngine.instance.destroyView(gxView)
+
                         if (gxTemplateContext.templateItem.isPageMode) {
                             GXRegisterCenter.instance.gxPageItemViewLifecycleListener?.onDestroy(gxView)
                         } else {
                             GXRegisterCenter.instance.gxItemViewLifecycleListener?.onDestroy(gxView)
                         }
+
+                        GXTemplateEngine.instance.destroyView(gxView)
                     }
                 }
             }

diff --git a/GaiaXAndroid/src/main/kotlin/com/alibaba/gaiax/render/view/container/GXScrollView.kt b/GaiaXAndroid/src/main/kotlin/com/alibaba/gaiax/render/view/container/GXScrollView.kt
@@ -69,12 +69,14 @@ open class GXScrollView : GXContainer, GXIRelease {
                         if (Log.isLog()) {
                             Log.e(gxTemplateContext.tag, "traceId=${gxTemplateContext.traceId} tag=GXScrollView.release GXScrollView=$this gxView=$gxView")
                         }
-                        GXTemplateEngine.instance.destroyView(gxView)
+
                         if (gxTemplateContext.templateItem.isPageMode) {
                             GXRegisterCenter.instance.gxPageItemViewLifecycleListener?.onDestroy(gxView)
                         } else {
                             GXRegisterCenter.instance.gxItemViewLifecycleListener?.onDestroy(gxView)
                         }
+
+                        GXTemplateEngine.instance.destroyView(gxView)
                     }
                 }
             }

diff --git a/GaiaXAndroid/src/main/kotlin/com/alibaba/gaiax/render/view/container/slider/GXSliderView.kt b/GaiaXAndroid/src/main/kotlin/com/alibaba/gaiax/render/view/container/slider/GXSliderView.kt
@@ -351,12 +351,13 @@ class GXSliderView : FrameLayout, GXIContainer, GXIViewBindData, GXIRootView,
                             if (Log.isLog()) {
                                 Log.e(gxTemplateContext.tag, "traceId=${gxTemplateContext.traceId} tag=GXSliderView.release GXSliderView=$this gxView=$gxView")
                             }
-                            GXTemplateEngine.instance.destroyView(gxView)
+
                             if (gxTemplateContext.templateItem.isPageMode) {
                                 GXRegisterCenter.instance.gxPageItemViewLifecycleListener?.onDestroy(gxView)
                             } else {
-                                GXRegisterCenter.instance.gxItemViewLifecycleListener?.onDestroy(gxView)
                             }
+
+                            GXTemplateEngine.instance.destroyView(gxView)
                         }
                     }
                 }

diff --git a/GaiaXAndroidDemo/app/src/main/kotlin/com/alibaba/gaiax/demo/ScrollTemplateActivity.kt b/GaiaXAndroidDemo/app/src/main/kotlin/com/alibaba/gaiax/demo/ScrollTemplateActivity.kt
@@ -233,7 +233,7 @@ class ScrollTemplateActivity : AppCompatActivity() {
                         val extend = templateData.data.getJSONObject("extend")
                         extend["scroll-index"] = it
                         extend["holding-offset"] = true
-                        extend["scroll-position"] = "right"
+                        extend["scroll-position"] = "center"
                         GXTemplateEngine.instance.bindData(view, templateData)
                     }
                 }