新增Toast和Dialog组件 #15
Open
新增Toast和Dialog组件 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
NeverEllipsis
commented
Sep 19, 2024
packages/bui-core/src/Input/index.md
Outdated
| @@ -181,7 +181,7 @@ export default () => { | |||
| <br /> | |||
| <Button onClick={multiplyTwo}>数量乘2(通过DOM操作value有效)</Button> | |||
| <br /> | |||
| <Input inputRef={reduceRef} defaultValue={defaultValue} /> | |||
There was a problem hiding this comment.
Input的两处改动应还原
| /** | ||
| * 自定义内容 | ||
| */ | ||
| desc?: Render; |
There was a problem hiding this comment.
命名保持统一：description
| /** | ||
| * 是否显示 | ||
| */ | ||
| visible?: boolean; |
There was a problem hiding this comment.
扩展了ModalProps，可以直接使用open，不需要再新增一个visible
| /** | ||
| * 内部<input>标签的标准属性 | ||
| */ | ||
| inputProps?: React.InputHTMLAttributes<HTMLInputElement>; |
There was a problem hiding this comment.
React not defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么?
新增Toast和Dialog组件，扩展弹层相关组件
这个变动的性质是？
这个变动涉及以下渠道:
附加信息（可选）
无