Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ucm2: add profile for the Samsung Galaxy Note II (Midas) #250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FrostI7Alex
Copy link

@FrostI7Alex FrostI7Alex commented Dec 14, 2022

Might need a few changes (output through the dock, for instance) in the future, but right now - it works.
If there are any changes required for this to get accepted - I'll make them, just tell me what do I need to do.

Copy link

@Newbytee Newbytee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice that you do this, but how does this work given that Galaxy S III uses the same "Midas" name? Is it able to avoid picking this one for S III somehow?

@FrostI7Alex
Copy link
Author

FrostI7Alex commented Dec 16, 2022

@Newbytee
Wouldn't the config in the device package overwrite this one?
Also, this should mostly work with the S III, except for the mics (based on what I saw in its current config), as I already mentioned on Matrix.
Would you mind testing this on an actual S III? If the boost value is too high, then it can be lowered to the S III's one. The Note II's value already feels as if it's over (or close to) the limit on the max volume, so lowering it to the S III's might be positive in the long run, in my opinion.

@jenneron
Copy link
Contributor

jenneron commented Dec 28, 2022

@Newbytee

how does this work given that Galaxy S III uses the same "Midas" name?

The same way. It will match "Midas" and use these configs

Is it able to avoid picking this one for S III somehow?

Yes, but they have to use different names

It can be overwritten in dts https://github.com/torvalds/linux/blob/3ba2d4bb9592bf7a6a3fe3dbe711ecfc3d004bab/arch/arm/boot/dts/exynos4412-midas.dtsi#L293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants