This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
[WIP] Get wifi_ssid in windows #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAC install script created ".attendance" in wrong place when multiple users exist and current user is not admin.
vibhoothi
suggested changes
Oct 12, 2019
| # get list of wifi ssid's | ||
| wifi_ssid_list = get_wifi_list() | ||
| # get wifi's ssid if the platform is windows | ||
| if _platform == "win32": |
There was a problem hiding this comment.
I was thinking how about if we add over get_wifi_list():(
instead of modifying here so we can add another condition like
if _platform == "win32":
.
.
so it will be looking uniform
| @@ -4,6 +4,7 @@ | |||
| import json | |||
|
|
|||
| import requests | |||
| import os | |||
There was a problem hiding this comment.
I am not sure why there was a use to import OS now?
| @@ -4,6 +4,7 @@ | |||
| import json | |||
|
|
|||
| import requests | |||
| import os | |||
There was a problem hiding this comment.
Suggested change
| import os |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit shall provide you a feature to get the WIFI SSiD in windows inorder to send the request to the server.