Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util_axis_fifo: Fix tkeep signal value when KEEP_EN is 0 #1455

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IstvanZsSzekely
Copy link
Contributor

PR Description

Changed the tkeep default value to be 0 regardless of data width then KEEP_EN is set to 0.
Wasn't tested on any of the project level testbenches or HDL projects and they shouldn't be affected either.
Tested in the DMAC IP level testbenches found in this repository, fixes a compilation issue and the test as well.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant