Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/library: Add axi_clock_monitor IP doc & Update IP GUI #1466

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IuliaCMoldovan
Copy link
Contributor

@IuliaCMoldovan IuliaCMoldovan commented Sep 25, 2024

PR Description

  • Added the doc. for AXI Clock Monitor IP core
  • Edited the GUI of the IP such that it displays the range of the valid values which can be assigned to NUM_OF_CLOCKS and the new link to the doc, in the company_url field
    I also added the warning to its corresponding wiki page, that it was migrated.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

PopPaul2021
PopPaul2021 previously approved these changes Sep 27, 2024
Copy link
Contributor

@PopPaul2021 PopPaul2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than updating the copyright year it looks good to me.

@IuliaCMoldovan
Copy link
Contributor Author

Other than updating the copyright year it looks good to me.

Thanks a lot for this, Paul! Eagle eyes 🦅

@IuliaCMoldovan
Copy link
Contributor Author

Built ad408x_fmc_ebz/zed which is the only project using this IP, and no issues were encountered.

@PopPaul2021 PopPaul2021 self-requested a review September 30, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants