Replace EmptyLogger with SimpleLogger for #28 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional tests for logging
|
Are there any further changes you require to this PR prior to merging, Andre? Any feedback which you could provide would be most welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new class Business::CPI::Util::SimpleLogger replaces the old Business::CPI::Util::EmptyLogger and includes some trivial methods for logging which act as a fallback in the absence of a more fully-featured user-provided logger such as Log::Log4Perl. The only significant difference is that SimpleLogger has a fatal() method which actually dies. If this is retained it would probably be advisable to have an explicit die immediately after calling fatal() in case it is over-ridden by a non-terminating method. eg:
There are some additional tests for these new logging methods as well.