Prepare extension for Firefox submission #999
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emccorson
force-pushed
the
firefox-investigation
branch
from
ad3bb9d
to
348356c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Add-on Policies
No Surprises
Depends on the add-on description. I think just go ahead with the Chrome add-on description and see what they say ☑️
Content
All good ☑️
Submission Guidelines
Need to submit a copy of the source code (more details in Source Code Submission guidelines).
UPDATE: We are ready for this ☑️
Development Practices
All good once #1003 is mergedMerged ☑️Data Disclosure, Collection and Management
We will need a privacy policy matching the guidelines here if what the extension does counts as data collection. I would guess we don't need one, but I'm not sure. Let's go ahead without one and see what they say ☑️
Monetization
All good ☑️
Security, Compliance and Blocking
All good ☑️
Source code submission
Provide your extension source code
We need to provide source code. We also need to add build instructions in the README and diff the build from the instructions against the extension build we are submitting.
UPDATE: Added in this PR ☑️
Default reviewer build environment
We have to provide details about the build environment or use the default reviewer one. I think the default one looks fine for building the extension but I will test against this to make sure.
UPDATE: All good ☑️
Use of obfuscated code
Should be OK ☑️
Source code checklist
All good ☑️