Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests & refactor tx crate - alt #3868

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Oct 2, 2024

Describe your changes

an alternative to #3835 (without the refactor of tx sections access 9842883, which breaks compatibility with hermes/gaia in a way I don't yet understand)

related to #1497

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic marked this pull request as ready for review October 2, 2024 11:28
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 81.89386% with 174 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@4110d8f). Learn more about missing BASE report.
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
crates/tx/src/section.rs 69.00% 137 Missing ⚠️
crates/tx/src/sign.rs 80.99% 23 Missing ⚠️
crates/tx/src/types.rs 98.39% 6 Missing ⚠️
crates/node/src/shell/finalize_block.rs 37.50% 5 Missing ⚠️
crates/node/src/shell/mod.rs 33.33% 2 Missing ⚠️
crates/node/src/shell/prepare_proposal.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3868   +/-   ##
=======================================
  Coverage        ?   73.20%           
=======================================
  Files           ?      341           
  Lines           ?   105183           
  Branches        ?        0           
=======================================
  Hits            ?    76994           
  Misses          ?    28189           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic added backport-44 merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass labels Oct 2, 2024
mergify bot added a commit that referenced this pull request Oct 2, 2024
Copy link
Contributor

mergify bot commented Oct 2, 2024

Hey @tzemanovic, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@tzemanovic
Copy link
Member Author

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Oct 2, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-44 merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants