Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More retryable http status codes #333

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

More retryable http status codes #333

wants to merge 2 commits into from

Conversation

gfmio
Copy link

@gfmio gfmio commented Aug 31, 2023

This PR increases the list of status codes considered retryable.

  • When Flink Statefun has high load, it can happen that the requests are sent too slowly and the server read timeout cuts off a request, in which case commonly a 400 error will be returned since the body was not parseable as a protobuf message.
  • When using a load balancer like Envoy, 503 and 504 errors can occur frequently when the upstream service is unavailable or e.g. getting redeployed.

@gfmio gfmio marked this pull request as ready for review August 31, 2023 11:11
@gfmio
Copy link
Author

gfmio commented Aug 31, 2023

Question for the maintainers: Do you think we should keep this a fixed list or shall we make this configurable as a comma separated list in either the flink config or the module.yaml?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gfmio