Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance exponential backoff #335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gfmio
Copy link

@gfmio gfmio commented Aug 31, 2023

This PR enhances the exponential backoff by adding jitter to prevent a thundering herd of requests.

The base backoff is increased to 1s, because 10ms can still create significant load on a service that might already be overwhelmed.

Finally, log messages are added or updated to provide useful diagnostic information in failure scenarios.

@gfmio gfmio marked this pull request as ready for review August 31, 2023 12:12
@gfmio gfmio changed the title enhance exponential backoff Enhance exponential backoff Aug 31, 2023
@gfmio
Copy link
Author

gfmio commented Aug 31, 2023

Question for the maintainers: Should we make the backoff settings configurable via the module.yaml?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant