add failed offset to Flink error messages #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,7 +45,7 @@ public RoutableKafkaIngressDeserializer(Map<String, RoutingConfig> routingConfig | |||
| public Message deserialize(ConsumerRecord<byte[], byte[]> input) { | |||
| final String topic = input.topic(); | |||
| final byte[] payload = input.value(); | |||
| final byte[] key = requireNonNullKey(input.key()); | |||
There was a problem hiding this comment.
Hi, I'd like your thoughts on the idea of incorporating the ability to skip records with null keys. Additionally, I'm thinking of making this functionality configurable. What are your thoughts on this?
kind: io.statefun.kafka.v1/ingress
spec:
id: localhost:9092
consumerGroupId: test-group-dev
startupPosition:
type: earliest
properties:
- isolation.level: read_committed
- security.protocol: SSL
- ssl.truststore.location: /tmp/flink/jks/truststore.jks
- ssl.truststore.password: changeit
- ssl.keystore.location: /tmp/flink/jks/kafka_keystore.jks
- ssl.keystore.password: test
- ssl.key.password: test
topics:
- topic: test-dev
skipNullKeyRecords: true
valueType: ua.Test
targets:
- ua.Test
default can be skipNullKeyRecords: false
There was a problem hiding this comment.
That might work. The NoOpDeserliazer just returns null, which could be done here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the topic, partition and offset to the error message when Flink encounters a null key to simplify finding the offending message.