in KnnVectorsWriter reduce code duplication w.r.t. MergedVectorValues.merge(Float|Byte)VectorValues #13539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Vigya Sharma <[email protected]>
cpoerschke
commented
Jul 3, 2024
| (docMap, values) -> { | ||
| return new ByteVectorValuesSub(docMap, values); | ||
| }), | ||
| mergeState); | ||
| } | ||
|
|
||
| static class MergedFloat32VectorValues extends FloatVectorValues { |
There was a problem hiding this comment.
And maybe this could drop the 32 for consistency with MergedByteVectorValues naming?
Suggested change
| static class MergedFloat32VectorValues extends FloatVectorValues { | |
| static class MergedFloatVectorValues extends FloatVectorValues { |
benwtrent
approved these changes
Jul 10, 2024
cpoerschke
commented
Jul 12, 2024
lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java
Outdated
Show resolved
Hide resolved
asfgit
pushed a commit
that referenced
this pull request
Jul 12, 2024
….merge(Float|Byte)VectorValues (#13539) Co-authored-by: Vigya Sharma <[email protected]> (cherry picked from commit c55d664)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by @vigyasharma's factoring out of a
validateFieldEncodingmethod in #13525 -- https://github.com/apache/lucene/pull/13525/files#r1664549231 -- included adapted version of that as the first commit on this PR's branch here