Refactor and javadoc update for KNN vector writer classes #13548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
reviewed
Jul 8, 2024
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99FlatVectorsFormat.java
Outdated
Show resolved
Hide resolved
| @@ -356,7 +356,7 @@ BufferedUpdate next() throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| BytesRef nextTerm() throws IOException { | |||
| private BytesRef nextTerm() throws IOException { | |||
There was a problem hiding this comment.
seems like an extra thing out of nowhere? Its probably ok in this commit, just struck me as a strange inclusion :)
There was a problem hiding this comment.
Yeah I just edited it when I was going over the code, thought it should be fine leaving it here :)
benwtrent
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description