use org.testcontainers:consul #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
changed the title
pjfanning
requested review from
raboof,
He-Pin,
nvollmar,
mdedetrich,
samueleresca and
Roiocam
He-Pin
reviewed
Aug 28, 2024
| pekko.discovery.pekko-consul { | ||
| consul-host = "${consul.getHost()}" | ||
| consul-port = $consulPort | ||
| } |
|
Thanks you @pjfanning, i am glad someone picked up this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host and Port for client are based on example in https://java.testcontainers.org/modules/consul/
The biggest issue with the change is the docker container for Consul has a non-deterministic port. So we need to construct a config with the mapped port.
Fixes #296