Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalatest to 3.2.18 #1116

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Update scalatest to 3.2.18 #1116

merged 4 commits into from
Feb 12, 2024

Conversation

scala-steward-asf[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates org.scalatest:scalatest from 3.2.17 to 3.2.18

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scalatest", artifactId = "scalatest" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalatest", artifactId = "scalatest" }
}]
labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

@mdedetrich
Copy link
Contributor

@pjfanning Isn't the better way to solve this problem just to pin the dependencies with a .scala-steward.conf or am I missing something?

@pjfanning
Copy link
Contributor

@mdedetrich you are suggesting that we skip scalatest 3.2.18 and stick with 3.2.17? It is a bit annoying of scalatest to upgrade to mockito and testng versions that don't support Java 8 in what in semver terms is a patch release.

@mdedetrich
Copy link
Contributor

I just realized that this repo is already on 1.1.x so you can ignore my previous comment. So yes we should figure out the core underlying issue.

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it is unfortunate we must use scalatest modules that are built for a different version of scalatest. Since these are only test dependencies that seems fine for now though.

Filed #1118 so we're reminded to fix this again once we move to requiring later Java versions for the build.

@pjfanning pjfanning merged commit 0f08ee5 into main Feb 12, 2024
18 checks passed
@pjfanning pjfanning deleted the update/scalatest-3.2.18 branch February 12, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants