chore: Refactor UnfoldResourceSourceAsync. #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
force-pushed
the
unfoldResourceAsync
branch
from
20fa8ea
to
db21255
Compare
He-Pin
commented
Apr 5, 2024
|
|
||
| private val createdCallback = getAsyncCallback[Try[S]] { | ||
| case Success(resource) => | ||
| require(resource != null, "`create` method should not return a null resource.") |
There was a problem hiding this comment.
the resource can be null, but can not now.
I think no one will returning a null resource
Maybe we should do the same in unfoldResource
|
Thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Refactory UnfoldResourceSourceAsync without change the order of type parameter instead of #616
Result:
Clean code and less allocation.
I think we should this when reading the code in #1240