Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration notes for SubstreamCancelStrategy deprecation #1391

Conversation

mdedetrich
Copy link
Contributor

@pjfanning @raboof @He-Pin @Roiocam @jxnu-liguobin Can you have a look into this just to confirm I didn't say anything wrong.

Related to #1205 (comment)

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jxnu-liguobin jxnu-liguobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdedetrich
Copy link
Contributor Author

Merging

@mdedetrich mdedetrich merged commit 07013eb into apache:main Jul 11, 2024
18 checks passed
@mdedetrich mdedetrich deleted the update-migration-docs-substream-cancel-subflow branch July 11, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants